fix: Used dumped state instead of fork #1399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maddiaa0
requested changes
Aug 3, 2023
| // anvil --fork-url https://mainnet.infura.io/v3/9928b52099854248b3a096be07a6b23c --fork-block-number 17514288 --chain-id 31337 | ||
| // For CI, this is configured in `run_tests.sh` and `docker-compose.yml` | ||
|
|
||
| const dumpedState = 'src/dumps/uniswap_state'; | ||
| const EXPECTED_FORKED_BLOCK = 0; //17514288; |
There was a problem hiding this comment.
nit - add a comment on how dumped state doesn't change block number but it works nevertheless
ludamad
changed the title
Maddiaa0
approved these changes
Aug 3, 2023
LHerskind
force-pushed
the
lh/uniswap_dumped_state
branch
from
6e4bbe4 to
4d04a4f
Compare
Will create a separate pr that fixed fixtures. There are also a couple of other files that would make sense to put in so would pollute this pr. |
codygunton
pushed a commit
that referenced
this pull request
Jan 23, 2024
* Updated fork block (#1396) * Updated fork block * Set redeploy flag * Redploy dev net (#1398) * Force redeploy (#1399) Co-authored-by: joss-aztec <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1367
Use a chain dump instead of forking for uniswap tests.
The sandbox is still using the fork.
Checklist:
Remove the checklist to signal you've completed it. Enable auto-merge if the PR is ready to merge.